LG 11140 Break up webauthn selection presenter #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Oct 31, 2023
Comment on lines
3
to
6
| def method | ||
| :webauthn_platform | ||
| end | ||
|
|
||
| def initialize(user:, configuration: nil) | ||
| @user = user | ||
| @configuration = configuration | ||
| end |
There was a problem hiding this comment.
I'd suggest reordering these methods so that the constructor is first.
Suggested change
| def method | |
| :webauthn_platform | |
| end | |
| def initialize(user:, configuration: nil) | |
| @user = user | |
| @configuration = configuration | |
| end | |
| def initialize(user:, configuration: nil) | |
| @user = user | |
| @configuration = configuration | |
| end | |
| def method | |
| :webauthn_platform | |
| end |
There was a problem hiding this comment.
Got that reordered.
| @@ -1,5 +1,5 @@ | |||
| module TwoFactorAuthentication | |||
| class WebauthnPlatformSelectionPresenter < SelectionPresenter | |||
| class SignInWebauthnPlatformSelectionPresenter < SelectionPresenter | |||
| def method | |||
| :webauthn_platform | |||
| end | |||
There was a problem hiding this comment.
I think we can remove checks below to configuration.blank?, since I would expect that the configuration should never be blank in the "Sign in" classes. They should be replaced with false.
kevinsmaster5
force-pushed
the
kmas-lg-11140-break-up-webauthn-selection-presenter
branch
from
3069918 to
4d2be38
Compare
kevinsmaster5
force-pushed
the
kmas-lg-11140-break-up-webauthn-selection-presenter
branch
from
4d2be38 to
3c30b5d
Compare
kevinsmaster5
deleted the
kmas-lg-11140-break-up-webauthn-selection-presenter
branch
aduth
reviewed
Nov 1, 2023
Comment on lines
+18
to
+26
| it 'raises with missing translation' do | ||
| expect(presenter.label).to eq( | ||
| t('two_factor_authentication.two_factor_choice_options.webauthn_platform'), | ||
| ) | ||
| end | ||
| end | ||
|
|
||
| describe '#info' do | ||
| it 'raises with missing translation' do |
There was a problem hiding this comment.
I just noticed these as I start work on a related ticket. These methods don't raise, so I think we should revise the expectation description accordingly.
Suggested change
| it 'raises with missing translation' do | |
| expect(presenter.label).to eq( | |
| t('two_factor_authentication.two_factor_choice_options.webauthn_platform'), | |
| ) | |
| end | |
| end | |
| describe '#info' do | |
| it 'raises with missing translation' do | |
| it 'returns the label text' do | |
| expect(presenter.label).to eq( | |
| t('two_factor_authentication.two_factor_choice_options.webauthn_platform'), | |
| ) | |
| end | |
| end | |
| describe '#info' do | |
| it 'returns the info text' do |
kevinsmaster5
added a commit
that referenced
this pull request
Nov 1, 2023
This reverts commit ccb2192.
aduth
reviewed
Nov 1, 2023
| @@ -17,19 +17,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#render_in' do | |||
There was a problem hiding this comment.
I think we lost test coverage here, we still have a SetUpWebauthnSelectionPresenter#render_in method.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11140
🛠 Summary of changes
Split up Webauthn & Webauthn Platform presenters into Sign Up and Sign In classes as a follow up to #9211
📜 Testing Plan
Adding Security key and Face or touch unlock MFA should continue to work as expected. Sign in with Security key or Face or touch unlock MFA should continue to work as expected.